My regex is matching too much. How do I make it stop?
I have this gigantic ugly string and I'm trying to extract pieces from it using regex. In this case, I want to grab everything after "Project Name" up to the part where it says "J0000011:" (the 11 is going to be a different number every time).
J0000000: Transaction A0001401 started on 8/22/2008 9:49:29 AM J0000010: Project name: E:\foo.pf J0000011: Job name: MBiek Direct Mail Test J0000020: Document 1 - Completed successfully
Here's the regex I've been playing with
The problem is that it doesn't stop until it hits the J0000020: at the end.
How do I make the regex stop at the first occurrence of
.* non-greedy by adding '
?' after it:
Read more... Read less...
Using non-greedy quantifiers here is probably the best solution, also because it is more efficient than the greedy alternative: Greedy matches generally go as far as they can (here, until the end of the text!) and then trace back character after character to try and match the part coming afterwards.
However, consider using a negative character class instead:
\S means “everything except a whitespace and this is exactly what you want.
".*" is a greedy selector. You make it non-greedy by using
".*?" When using the latter construct, the regex engine will, at every step it matches text into the
"." attempt to match whatever make come after the
".*?". This means that if for instance nothing comes after the
".*?", then it matches nothing.
Here's what I used.
s contains your original string. This code is .NET specific, but most flavors of regex will have something similar.
string m = Regex.Match(s, @"Project name: (?<name>.*?) J\d+").Groups["name"].Value;
I would also recommend you experiment with regular expressions using "Expresso" - it's a utility a great (and free) utility for regex editing and testing.
One of its upsides is that its UI exposes a lot of regex functionality that people unexprienced with regex might not be familiar with, in a way that it would be easy for them to learn these new concepts.
For example, when building your regex using the UI, and choosing "*", you have the ability to check the checkbox "As few as possible" and see the resulting regex, as well as test its behavior, even if you were unfamiliar with non-greedy expressions before.
Available for download at their site: http://www.ultrapico.com/Expresso.htm
Express download: http://www.ultrapico.com/ExpressoDownload.htm
This will work for you.
Adding (?:\\w+)+.[a-zA-Z]+ will be more restrictive instead of .*